Fix support for HTTPS proxies #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rattrayalex-stripe
cc @stripe/api-libraries
When I enabled persistent connections in #560, I broke support for HTTPS proxies: instances of
HttpsProxyAgentare not instances ofhttps.Agent, so they are assigned tohttp_agentinstead ofhttps_agent.Rather than try to store all possible agent types in the correct variable, this PR reverts to the previous behavior of storing the agent in
agentregardless of its type. Ifagentis null,StripeResourcewill use a default agent of the correct type depending on whether the request uses HTTP or HTTPS.Fixes #579.