Handle Buffer instances in Webhook.constructEvent #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm 👍 |
|
Released as 6.15.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jlomas-stripe
cc @stripe/api-libraries
Handle
Bufferinstances inWebhook.constructEvent, by silently converting them to UTF-8 strings.Firebase returns the raw body as a
Bufferinstance, so this lets users directly passrequest.rawBodyto theconstructEventmethod, without having to do the string conversion themselves.(What happens currently is that the buffer is coerced into a string when we compute the signed payload with the timestamp, but since no explicit encoding is applied, this can apparently cause issues in some cases, cf. #341 (comment)).