Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Reporting resources #493

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

remi-stripe
Copy link
Contributor

Adding support for the new Reporting resources. Those are in OpenAPI but not yet public but since they are starting to be used and are stable we should merge them.

It's WIP for now while I get some feedback on the implementation and the shape of the resources.

cc @stripe/api-libraries
cc @brahn-stripe

@remi-stripe remi-stripe changed the title Add support for the Reporting resources [WIP] Add support for the Reporting resources Aug 31, 2018
@remi-stripe remi-stripe changed the title [WIP] Add support for the Reporting resources Add support for the Reporting resources Sep 5, 2018
@remi-stripe
Copy link
Contributor Author

r? @ob-stripe


module.exports = StripeResource.extend({
path: 'reporting/report_types',
includeBasic: ['create', 'list', 'retrieve'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'create'.

@remi-stripe
Copy link
Contributor Author

@ob-stripe Fixed, PTAL

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Sep 5, 2018
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Sep 5, 2018
@ob-stripe ob-stripe merged commit e34b138 into master Sep 5, 2018
@ob-stripe ob-stripe deleted the remi-add-reporting-resources branch September 5, 2018 22:36
@ob-stripe
Copy link
Contributor

Released as 6.9.0.

@mbifulco
Copy link

Are there docs anywhere for reporting resources?

@ob-stripe
Copy link
Contributor

@mbifulco This feature is still in private beta for now. If it sounds like something you'd be interested in, you should reach out to support at https://support.stripe.com/email to ask for more information and see if you could be invited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants