fix invalid path join #436

[dreisel]

pathWithSymbols may be undefined and then an exception is thrown from the path.join method.
bug details: #436

[ob-stripe]

@Reisel Thanks for the fix, however we cannot use it as-is as the default parameter syntax was only enabled by default in Node v6 [1], and the library still needs to support v4.

Can you change the fix to do something like var pathWithSymbols = typeof pathWithSymbols !== 'undefined' ? pathWithSymbols : '';?

[1] https://node.green/#ES2015-syntax-default-function-parameters

[dreisel]

@ob-stripe how about

createResourcePathWithSymbols: function(pathWithSymbols) {
    return '/' + path.join(
      this.resourcePath,
      pathWithSymbols || ''
    ).replace(/\\/g, '/'); // ugly workaround for Windows
  }

[ob-stripe]

Yeah, I think that'd be fine too :)

[dreisel]

@ob-stripe updated.

[ob-stripe]

👍