Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for /v1/topups endpoints #425

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Conversation

jkakar-stripe
Copy link
Contributor

@jkakar-stripe jkakar-stripe commented Feb 13, 2018

This add standard retrieve, create and update client support for the new /v1/topups endpoint.

@jkakar-stripe
Copy link
Contributor Author

@stripe/api-libraries I've done some poking around, but I don't know much about Node, and am confused about the failure here. It seems unrelated to my changes. I'd appreciate any advice you have about moving this forward, please.

@brandur-stripe
Copy link
Contributor

Hm, we might have a build failure on master due to a relatively recent API change. The last build was two months ago — I just triggered a rebuild to check.

@brandur-stripe
Copy link
Contributor

Added #426 to fix the failing test suite.

@brandur-stripe
Copy link
Contributor

That failing test should be fixed now if you rebase against master.

@jkakar-stripe jkakar-stripe changed the title [wip] Add support for /v1/topups endpoints Add support for /v1/topups endpoints Feb 13, 2018
@jkakar-stripe
Copy link
Contributor Author

Thanks @brandur-stripe!

@jkakar-stripe
Copy link
Contributor Author

@jkakar-stripe
Copy link
Contributor Author

r? @stripe/api-libraries

@brandur-stripe
Copy link
Contributor

LGTM. Thanks Jamu!

@apakulov-stripe
Copy link

@stripe/api-libraries are we ready to merge it?

@brandur-stripe
Copy link
Contributor

LGTM.

@brandur-stripe brandur-stripe merged commit 96f6dd6 into master Feb 21, 2018
@brandur-stripe brandur-stripe deleted the jkakar/topup-client branch February 21, 2018 19:41
@brandur-stripe
Copy link
Contributor

Released as 5.5.0.

@jeveloper
Copy link

Could someone provide documentation on how to use this please?

Thanks
I've only found an event referring topups but not actual description , fees ....

@ob-stripe
Copy link
Contributor

Hi @jeveloper, this is an upcoming feature that's not yet publicly available or documented.

@jeveloper
Copy link

@ob-stripe ooooh now im excited
No fee balance holding top up feature , i have a use case for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants