More explicitly call out that constructEvent needs the raw body
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. I did the release before seeing this, but we can always do another one. Can you check the build failure? I think there's a check on line length that you might need to fix. |
jlomas-stripe
force-pushed
the
jlomas-signature-warning
branch
from
92f6638
to
ab7968d
Compare
|
No worries - this is one of those 'whenever' things, I think. ...I still can't get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is something that comes up a lot, I thought it might be worth calling it out a bit more explicitly, both in the Readme and in the Error we return when the signatures don't match.
r? @brandur-stripe