fix: Stop using path.join to create URLs.

lib/StripeResource.js

@@ -1,7 +1,5 @@
 'use strict';
 
-const path = require('path');
-
 const utils = require('./utils');
 const {
   StripeConnectionError,
@@ -71,22 +69,26 @@ StripeResource.prototype = {
   validateRequest: null,
 
   createFullPath(commandPath, urlData) {
-    return path
-      .join(
-        this.basePath(urlData),
-        this.path(urlData),
-        typeof commandPath == 'function' ? commandPath(urlData) : commandPath
-      )
-      .replace(/\\/g, '/'); // ugly workaround for Windows
+    return this._joinUrlParts([
+      this.basePath(urlData),
+      this.path(urlData),
+      typeof commandPath == 'function' ? commandPath(urlData) : commandPath,
+    ]);
   },
 
   // Creates a relative resource path with symbols left in (unlike
   // createFullPath which takes some data to replace them with). For example it
   // might produce: /invoices/{id}
   createResourcePathWithSymbols(pathWithSymbols) {
-    return `/${path
-      .join(this.resourcePath, pathWithSymbols || '')
-      .replace(/\\/g, '/')}`; // ugly workaround for Windows
+    return `/${this._joinUrlParts([this.resourcePath, pathWithSymbols || ''])}`;
+  },
+
+  _joinUrlParts(parts) {
+    // Replace any accidentally doubled up parenthesis. This previously used
+    // path.join, which would do this as well. Unfortuantely we need to do this
+    // as the functions for creating paths are technically part of the public
+    // interface and so we need to preserve backwards compatibility.
+    return parts.join('/').replace(/\/\//g, '/');
   },
 
   // DEPRECATED: Here for backcompat in case users relied on this.

lib/makeRequest.js

@@ -12,7 +12,6 @@ function getRequestOpts(self, requestArgs, spec, overrideData) {
   const commandPath = utils.makeURLInterpolator(
     isUsingFullPath ? spec.fullPath : spec.path || ''
   );
-
   // When using fullPath, we ignore the resource path as it should already be
   // fully qualified.
   const path = isUsingFullPath

test/StripeResource.spec.js

@@ -27,6 +27,12 @@ describe('StripeResource', () => {
       const path = stripe.invoices.createResourcePathWithSymbols('{id}');
       expect(path).to.equal('/invoices/{id}');
     });
+
+    it('Handles accidental double slashes', () => {
+      stripe.invoices.create({});
+      const path = stripe.invoices.createResourcePathWithSymbols('/{id}');
+      expect(path).to.equal('/invoices/{id}');
+    });
   });
 
   describe('_makeHeaders', () => {
@@ -94,6 +100,17 @@ describe('StripeResource', () => {
         });
       });
 
+      it('handles . as a query param', (done) => {
+        const scope = nock(`https://${stripe.getConstant('DEFAULT_HOST')}`)
+          .get('/v1/customers/.', '')
+          .reply(200, '{}');
+
+        realStripe.customers.retrieve('.', (err, response) => {
+          done(err);
+          scope.done();
+        });
+      });
+
       it('works correctly with undefined optional arguments', (done) => {
         const scope = nock(`https://${stripe.getConstant('DEFAULT_HOST')}`)
           .get('/v1/accounts/acct_123')