Upgrade devDependencies #1146
Merged
Upgrade devDependencies #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh stop the presses, we lose node 8 in CI with this. |
|
Node 8 is past EOL, so maybe we should just drop support for it :) |
richardm-stripe
changed the title
richardm-stripe
force-pushed
the
richardm-bump-mocha
branch
from
42cd76f
to
e0be648
Compare
|
I agree but we should do that in a major. |
richardm-stripe
force-pushed
the
richardm-bump-mocha
branch
from
e0be648
to
8b15e10
Compare
richardm-stripe
force-pushed
the
richardm-bump-mocha
branch
from
8b15e10
to
0cf339a
Compare
richardm-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps some devDependencies that are marked as vulnerable. This is merely for hygiene: the vulnerabilities do not affect this library -- we do not rely on the vulnerable code paths, nor does the development workflow involve live traffic.
The upgraded dependencies are not compatible with Node 8, and so this PR also disables Node 8 in CI. We hope to officially deprecate Node 8 soon, but in the meantime we will be not be able to rely on CI to be sure Node 8 does not break and should verify that any potentially incompatible changes are tested manually.
cc @stripe/api-libraries
r? @stripe/api-library-reviewers