Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1280

Merged
merged 3 commits into from
May 6, 2021
Merged

API Updates #1280

merged 3 commits into from
May 6, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented May 6, 2021

r? @remi-stripe
cc @stripe/api-libraries

Corresponds to Stripe Openapi release v33. Analogous typescript diff.

Changelog

  • Add support for Reference on ChargePaymentMethodDetailsAfterpayClearpay.
  • Add support for AfterpayClearpay on PaymentIntentPaymentMethodOptionsParams.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but one alphabetical order is wrong

Sofort *PaymentIntentPaymentMethodOptionsSofortParams `form:"sofort"`
ACSSDebit *PaymentIntentPaymentMethodOptionsACSSDebitParams `form:"acss_debit"`
Alipay *PaymentIntentPaymentMethodOptionsAlipayParams `form:"alipay"`
AfterpayClearpay *PaymentIntentPaymentMethodOptionsAfterpayClearpayParams `form:"afterpay_clearpay"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be before Alipay in alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

paymentintent.go Outdated Show resolved Hide resolved
@richardm-stripe richardm-stripe merged commit 888b638 into master May 6, 2021
@richardm-stripe richardm-stripe deleted the richardm-afterpayclearpay-pmo branch July 10, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants