Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the custom request handler call after the main ACL check #189

Conversation

sergeyrud-stripe
Copy link
Contributor

Running a custom request handler after a successful ACL check is more useful for certain use cases. I.e. if a request is denied by checkIfRequestShouldBeProxied, this request might be irrelevant for CustomRequestHandler.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5068985840

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 62.476%

Totals Coverage Status
Change from base Build 5024495973: -0.04%
Covered Lines: 1292
Relevant Lines: 2068

💛 - Coveralls

@sergeyrud-stripe sergeyrud-stripe force-pushed the sergeyrud-move-custom-request-handler-after-the-main-check branch from a33f085 to 445d0d6 Compare May 31, 2023 09:38
@coveralls
Copy link

coveralls commented May 31, 2023

Pull Request Test Coverage Report for Build 5068985840

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 62.476%

Files with Coverage Reduction New Missed Lines %
pkg/smokescreen/config.go 40 34.26%
Totals Coverage Status
Change from base Build 5024495973: -0.04%
Covered Lines: 1292
Relevant Lines: 2068

💛 - Coveralls

Copy link
Contributor

@kevinv-stripe kevinv-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

For other smokescreen users: if this change breaks your implementation please file an issue and we'll address it ASAP.

@kevinv-stripe kevinv-stripe merged commit 8dd3072 into master May 31, 2023
@kevinv-stripe kevinv-stripe deleted the sergeyrud-move-custom-request-handler-after-the-main-check branch May 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants