Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in documentation #5619

Merged
merged 2 commits into from
May 6, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

I have planned to fix all links in documentation.

@Jean-BaptisteC Jean-BaptisteC changed the title Fix documentation Fix links in documentation May 6, 2024
@HolgerJeromin
Copy link
Contributor

ref 6fe3387

CONTRIBUTING_A_NEW_QUEST.md Outdated Show resolved Hide resolved
@Jean-BaptisteC
Copy link
Contributor Author

ref 5a2286b

@Jean-BaptisteC Jean-BaptisteC marked this pull request as ready for review May 6, 2024 10:09
@Jean-BaptisteC
Copy link
Contributor Author

All links in documentation has been tested

@matkoniecz matkoniecz merged commit 7b79657 into streetcomplete:master May 6, 2024
@matkoniecz
Copy link
Member

matkoniecz commented May 6, 2024

At some point I will get that dead link detector running...

This should have been detected automatically.

(I started working on it and run into bugs in libraries I was planning to use - I should look whether they fixed them or just write spider + error checker myself)

@Jean-BaptisteC Jean-BaptisteC deleted the doc_links branch May 6, 2024 10:51
@mnalis
Copy link
Member

mnalis commented May 6, 2024

At some point I will get that dead link detector running...

Something like this (have not tried)?
https://andrewwegner.com/find-broken-links-with-github-actions.html

@matkoniecz
Copy link
Member

matkoniecz commented May 6, 2024

https://andrewwegner.com/find-broken-links-with-github-actions.html

I use broken-link-checker for now. I picked this because I'm familiar with it. It hasn't been updated since 2018, though, so in the future I may spend some time either looking for an alternative or building an alternative. For the time being though, it works just fine.

Well, for me it is not working fine - see stevenvachon/broken-link-checker#234 (it is one of projects I tried)

@riQQ riQQ mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants