Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix dev server error - back out bad change #9753

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 4, 2020

Issue: #9749

What I did

Revert bad change to dev server. It's not actually failing in my local dev server (official-storybook), so I'm not sure how to repro. But it seems to be affecting a lot of people, so trusting the crowd here.

How to test

N/A - not sure how to repro

@shilman shilman added this to the 5.3.x milestone Feb 4, 2020
@shilman shilman merged commit 7ca2482 into next Feb 4, 2020
@shilman shilman deleted the 9749-fix-dev-server branch February 4, 2020 23:08
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Feb 4, 2020
shilman added a commit that referenced this pull request Feb 4, 2020
Fix dev server error - back out bad change
@shilman shilman changed the title Fix dev server error - back out bad change Core: Fix dev server error - back out bad change Feb 4, 2020
sh0ji added a commit to wwnorton/design-system that referenced this pull request Jul 17, 2020
5.3.11 had a change that broke the storybook server.
storybookjs/storybook#9753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants