Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8297 Fix "storybook/source-loader/set" event parameters in "addon-storysource" #9561

Closed
wants to merge 1 commit into from
Closed

#8297 Fix "storybook/source-loader/set" event parameters in "addon-storysource" #9561

wants to merge 1 commit into from

Conversation

LeeBurton
Copy link

Fixes the "storybook/source-loader/set" event parameters in the "addon-storysource" addon, introduced by the following changes:

https://github.com/storybookjs/storybook/pull/7272/files#diff-904dad7f92c7bbfac64aca74960bbf33

Referenced in the following issue:

Issue: #8297

What I did

How to test

  1. add .addDecorator(withStorySource('test')) to stories, or:

    addons.getChannel().emit('storybook/source-loader/set', { edition: { source: 'source' }, location: {currentLocation: undefined, locationsMap: {}} });

  2. add the following to the .storybook/webpack.config.js file:

    { loader: require.resolve('@storybook/source-loader'), options: { injectDecorator: false } }

Then the code should be loaded successfully in the "Story" Panel. if the Injector is not disabled, the stories decorator code is overwritten by the loader.

…orysource" addon

Fix the "storybook/source-loader/set" event parameters  in the "addon-storysource" addon, introduced by the following changes:

    https://github.com/storybookjs/storybook/pull/7272/files#diff-904dad7f92c7bbfac64aca74960bbf33

Referenced in the following issue:

    #8297
@vercel
Copy link

vercel bot commented Jan 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/p6uwjypgu
✅ Preview: https://monorepo-git-fork-smokinmedia-8297-fix-addon-stor-2e4869.storybook.now.sh

@stale
Copy link

stale bot commented Feb 10, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 10, 2020
@shilman
Copy link
Member

shilman commented Feb 10, 2020

@LeeBurton we recently overhauled source-loader and addon-storysource as part of 6.0. if you have time, please give them a try.

@stale stale bot removed the inactive label Feb 10, 2020
@stale
Copy link

stale bot commented Mar 3, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 3, 2020
@stale
Copy link

stale bot commented Apr 2, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants