Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sass-loader to 7.0.1 & stop bringing node-sass bin to each user #3467

Merged
merged 1 commit into from
Apr 21, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3425

This update allows us to stop making users download a large node-sass binary even if they don't use sass/scss at all.

See also: webpack-contrib/sass-loader#532

@ndelangen
Copy link
Member

I'm OK with this..

@codecov
Copy link

codecov bot commented Apr 21, 2018

Codecov Report

Merging #3467 into master will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
- Coverage   37.56%   37.14%   -0.43%     
==========================================
  Files         459      465       +6     
  Lines       10235    10320      +85     
  Branches      924      934      +10     
==========================================
- Hits         3845     3833      -12     
- Misses       5816     5937     +121     
+ Partials      574      550      -24
Impacted Files Coverage Δ
addons/graphql/src/components/FullScreen/index.js 0% <0%> (-80%) ⬇️
addons/graphql/src/components/FullScreen/style.js 0% <0%> (-66.67%) ⬇️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.33% <0%> (ø) ⬆️
addons/knobs/src/angular/helpers.js 76.76% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/search_box.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/mithril/WrapStory.js 0% <0%> (ø) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29b6c4...b1ca049. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5df47a4 into master Apr 21, 2018
@Hypnosphi Hypnosphi deleted the upgrade-sass-loader branch April 21, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants