Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN app: upgrade ws from 3.3.3 to 4.1.0 #3074

Merged
merged 2 commits into from
Feb 27, 2018
Merged

RN app: upgrade ws from 3.3.3 to 4.1.0 #3074

merged 2 commits into from
Feb 27, 2018

Conversation

Hypnosphi
Copy link
Member

Fixes #2658

How to test

Launch CRNA example

We don't seem to need any migration, see websockets/ws#1256 (comment)

@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #3074 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3074   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files         438      438           
  Lines        9447     9447           
  Branches      907      900    -7     
=======================================
  Hits         3409     3409           
- Misses       5460     5476   +16     
+ Partials      578      562   -16
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
addons/storysource/src/loader/inject-decorator.js 30.43% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️
addons/knobs/src/angular/helpers.js 76.97% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6758750...5c8dd67. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 2b81544 into master Feb 27, 2018
@Hypnosphi Hypnosphi deleted the upgrade-ws branch February 27, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants