Fix problem with RN on latest master build

[tmeasday]

Issue: I guess RN is broken on master.

I thought I was testing my changes in #3036, but apparently not. What is the latest procedure for install local changes into RN example apps?

What I did

Fixed a bug in the CRNA example app.

How to test

Ensure the RN example apps actually work!

[Hypnosphi]

What is the latest procedure for install local changes into RN example apps?

Unfortunately, you have to do yarn bootstrap --reset --core --reactnativeapp after each change

cc @danielduan

[codecov]

Codecov Report

Merging #3045 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3045   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files         417      417           
  Lines        9849     9849           
  Branches      838      821   -17     
=======================================
  Hits         3632     3632           
- Misses       5741     5750    +9     
+ Partials      476      467    -9

Impacted Files	Coverage Δ
lib/core/src/client/preview/client_api.js	90.81% <100%> (ø)	⬆️
addons/a11y/src/components/Report/Item.js	0% <0%> (ø)	⬆️
addons/events/src/components/Event.js	37.64% <0%> (ø)	⬆️
lib/ui/src/libs/key_events.js	33.96% <0%> (ø)	⬆️
.../src/modules/ui/components/stories_panel/header.js	29.62% <0%> (ø)	⬆️
lib/core/src/client/preview/story_store.js	84.21% <0%> (ø)	⬆️
lib/core/src/client/preview/syncUrlWithStore.js	39.13% <0%> (ø)	⬆️
...dons/actions/src/lib/types/object/getObjectName.js	62.5% <0%> (ø)	⬆️
addons/viewport/src/components/RotateViewport.js	22.72% <0%> (ø)	⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js	0% <0%> (ø)	⬆️
... and 55 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab8276...a47b496. Read the comment docs.

[tmeasday]

Maybe the --reset part was what I was missing. Does that do the destructive "delete everything" step?

[Hypnosphi]

Yep

[danielduan]

RN is a pain to develop on unfortunately because of the many dependencies it needs. I wonder if there's anything we can do to make it easier.

[Hypnosphi]

There was an attempt in #2375

[ndelangen]

I still have a POC branch that mostly worked RN + yarn workspaces, but it's old. If you want to take a look I can push it.

I lost 5 sanity points working it that

[tmeasday]

It looks like there may have been recent developments within Metro bundler which might? make this better?: facebook/metro#1 (comment)