Config: Apply JavaScript-only story glob extensions for JavaScript projects #28338
Conversation
valentinpalkovic
added
ci:daily
valentinpalkovic
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 74646c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
force-pushed
the
valentin/fix-story-glob-pattern
branch
2 times, most recently
from
fde3d6f
to
01c12fa
Compare
valentinpalkovic
force-pushed
the
valentin/fix-story-glob-pattern
branch
from
01c12fa
to
74646c6
Compare
| @@ -92,7 +92,7 @@ const publish = async (packages: { name: string; location: string }[], url: stri | |||
| const command = `cd ${path.resolve( | |||
| '../code', | |||
| location | |||
| )} && yarn pack --out=${PACKS_DIRECTORY}/${tarballFilename} && cd ${PACKS_DIRECTORY} && npm publish ./${tarballFilename} --registry ${url} --force --access restricted --ignore-scripts`; | |||
| )} && yarn pack --out=${PACKS_DIRECTORY}/${tarballFilename} && cd ${PACKS_DIRECTORY} && npm publish ./${tarballFilename} --registry ${url} --force --ignore-scripts`; | |||
There was a problem hiding this comment.
For some reason, it is impossible to build sandboxes locally in no-link mode. It seems, that non-scoped packages cannot be released in a restricted way
There was a problem hiding this comment.
I ran into the same problem in the CPC branch, but I figured it was due to something I changed.
I resolved it the same way; there seems no reason to restrict access.
|
@valentinpalkovic Is this PR by any chance related to the error which I am facing?
|
|
No, I don't think it is related. |
|
@valentinpalkovic Can you guide a little about what measures could be taken? |
Closes N/A
What I did
For new Storybook initializations, the Story glob file extension pattern will be limited to JavaScript-only files if we detect that the project is a JavaScript-only project.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --template cra/default-js --no-linkDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>