Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Allow outputPath object syntax #28144

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jun 7, 2024

Closes #28143

What I did

I have fixed an issue where outputPath in Angular's workspace configuration might cause issues in Storybook, if it is defined as an object.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Checkout https://stackblitz.com/edit/github-uzgadq-yz5lzq?file=angular.json
  2. Install the canary of this PR
  3. Storybook should start as expected

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28144-sha-88097b55. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28144-sha-88097b55 sandbox or in an existing project with npx storybook@0.0.0-pr-28144-sha-88097b55 upgrade.

More information
Published version 0.0.0-pr-28144-sha-88097b55
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/angular-output-path-object
Commit 88097b55
Datetime Fri Jun 7 12:28:11 UTC 2024 (1717763291)
Workflow run 9416980443

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28144

Copy link

nx-cloud bot commented Jun 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 88097b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review June 7, 2024 12:54
@shilman shilman merged commit 60c7320 into next Jun 8, 2024
65 of 67 checks passed
@shilman shilman deleted the valentin/angular-output-path-object branch June 8, 2024 13:06
@github-actions github-actions bot mentioned this pull request Jun 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants