Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Upgrade deps of @storybook/test #27862

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

kasperpeulen
Copy link
Contributor

Closes #27173

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Jun 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 40b1799. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen force-pushed the kasper/upgrade-test-deps branch 2 times, most recently from 56fa0e9 to f0023bd Compare June 5, 2024 14:13
"@testing-library/user-event": "^14.5.2",
"@vitest/expect": "1.3.1",
"@vitest/spy": "^1.3.1",
"@testing-library/dom": "10.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this theoretically a breaking change?

BREAKING CHANGES
Minimum supported Node.js version is 18.0
New version of aria-query changes various roles. Check out the changed tests in testing-library/dom-testing-library@2c57055 to get an overview about what changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperpeulen kasperpeulen merged commit 194f713 into next Jun 6, 2024
59 of 61 checks passed
@kasperpeulen kasperpeulen deleted the kasper/upgrade-test-deps branch June 6, 2024 11:19
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
13 tasks
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 14, 2024
This was referenced Jun 15, 2024
shilman added a commit that referenced this pull request Jun 18, 2024
Test: Upgrade deps of @storybook/test
(cherry picked from commit 194f713)
shilman pushed a commit that referenced this pull request Jun 27, 2024
Test: Upgrade deps of @storybook/test
(cherry picked from commit 194f713)
shilman pushed a commit that referenced this pull request Jun 27, 2024
Test: Upgrade deps of @storybook/test
(cherry picked from commit 194f713)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
3 participants