Angular: Fix wrong detection of standalone components #27353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26056
What I did
@gionkunz and I had a look at it. We found the issue and a solution.
Issue:
The old implementation checks whether a directive or component in the dependency structure is a standalone component. It does not matter where the standalone component is located in the dependency structure. It is sufficient if only one component is standalone. That goes wrong.
Solution:
reflectionCapabilities.annotations returns an array with decorators of the inheritance hierarchy.
https://github.com/angular/angular/blob/825023801baf8dbd0bd87b7ec46a65e869e08adb/packages/core/src/reflection/reflection_capabilities.ts#L204-L212
Because
parentAnnotations.concat(ownAnnotations);
The actual component to be imported is located somewhere at the end of the array.Example from
storybook/code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Lines 170 to 181 in 122a83f
As we do not know exactly what is returned, we look for the first decorator in the reverse array that is a component or a directive. It is only on this decorator that we need to check whether it is a standalone component or not. This works because the hierarchically lowest component takes care of the imports.
We have encountered the error in version 7.6.6. It would be ideal if the fix would also lead to a new 7.6.x version.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I monkey patched the fix in our project with version 7.6.6 where we encountered this problem. We no longer had this issue. The stories were rendered correctly and there were no errors.
I tried to make it run in the sandbox, but there were too many problems (not from this fix), for example: #26439
If you get it to run, it should be reproducible as follows: #26829 (comment)
yarn task --task sandbox --start-from auto --template angular-cli/default-ts
cd sandoox/angular-cli-default-ts
yarn storybook
Documentation
No changes required
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>