Angular: Reduce the warnings from ts-loader via stricter list of includes
#24531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
ts-loader by specifying stricter list of includes
ndelangen
changed the title
ts-loader by specifying stricter list of includests-loader via stricter list of includes
ndelangen
added
bug
angular
ci:merged
valentinpalkovic
approved these changes
Oct 20, 2023
|
@valentinpalkovic I could use your help here 🙏 |
|
@ndelangen I am a bit confused here. Now, it seems that every file part of the compilation must be mentioned. When we tested things, it was necessary to add only the entry points, instead of all files. I will take a closer look on Monday. |
|
Do we keep this open @valentinpalkovic ? |
|
Yes we do. |
valentinpalkovic
requested review from
tmeasday and
kasperpeulen
as code owners
valentinpalkovic
approved these changes
Dec 11, 2023
valentinpalkovic
force-pushed
the
norbert/fix-24487-angular-tsconfig
branch
from
c742175
to
2ee9a72
Compare
22 tasks
This was referenced Feb 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24487
What I did
I changed the
includeslist so it only targets story files.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
@valentinpalkovic & @yannbf could you assist me in remembering if this was the solution we discussed on Tuesday?
@yannbf you had a project that showed the symptoms from #24487 was it this project: https://github.com/bitwarden/clients ?
We might want to release a canary of this and test it out?
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>