Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented webpack customization example for typescript #1386

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

tko
Copy link
Contributor

@tko tko commented Jun 29, 2017

Provides a copypastable starting point for a quick start and typescript
for those who want it.

Not sure if fixes #875 as the issue mentions storyshots which I have no experience with.

How to test

  1. build new docs
  2. browse to http://localhost:8000/configurations/custom-webpack-config/#full-control-mode-default

Provides a copypastable starting point for a quick start and typescript
for those who want it.
@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #1386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1386   +/-   ##
=======================================
  Coverage   14.35%   14.35%           
=======================================
  Files         201      201           
  Lines        4613     4613           
  Branches      498      498           
=======================================
  Hits          662      662           
- Misses       3517     3522    +5     
+ Partials      434      429    -5
Impacted Files Coverage Δ
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f791c...69aeb96. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great addition 😄

@shilman shilman changed the title docs: add webpack customization example for typescript support Add webpack customization example for typescript to docs Jun 29, 2017
@shilman shilman changed the title Add webpack customization example for typescript to docs Documented webpack customization example for typescript Jun 29, 2017
@shilman shilman merged commit 638392c into storybookjs:master Jun 29, 2017
@tko tko deleted the docs-typescript branch June 29, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants