Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marksy initialized with mtrcConf intead of marksyConf #1205

Merged

Conversation

elisherer
Copy link
Contributor

Issue: mtrc was replaced with marksy, one replace of mtrcConf with marksyConf was missed

What I did

replaced the missed replacement (see 1 file changed)

How to test

Pass marksyConf to options and see it's effective

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #1205 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      523      536   +13     
=======================================
  Hits          611      611           
+ Misses       3537     3502   -35     
- Partials      441      476   +35
Impacted Files Coverage Δ
addons/info/src/components/Story.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 7.14% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 30.13% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b68a5...8f1bf37. Read the comment docs.

@ndelangen
Copy link
Member

Good eye! Thanks !

@ndelangen ndelangen merged commit 64683a1 into storybookjs:master Jun 6, 2017
@ndelangen ndelangen changed the title [addon-info] fix bug marksy initialized with mtrcConf intead of marksyConf Marksy initialized with mtrcConf intead of marksyConf Jun 7, 2017
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants