Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marksy dependecy due broken 1.1.0 version #1204

Merged
merged 2 commits into from
Jun 6, 2017
Merged

Update marksy dependecy due broken 1.1.0 version #1204

merged 2 commits into from
Jun 6, 2017

Conversation

nezed
Copy link
Contributor

@nezed nezed commented Jun 6, 2017

Important issue:
Current addon-info dependecy marksy: ^1.0.1 resolves as 1.1.0 which brings to Storybook an error

Prism is not defined
ReferenceError: Prism is not defined
    at CodeComponent (http://localhost:9001/static/preview.bundle.js:89694:119)

This error leads to #163 issue with confusing answer, because marksy already switched from Prism to HiglightJS in version 2.0.0
(See storybookjs/marksy#11)

There is no breaking changes betwen 1.1.0 and 2.0.0 versions of marksy

What I did

Updated marksy dependecy version for @storybook/addon-info

How to test

Write any story description that can lead to markdown parsing.
My case is:

storiesOf('SomeComponent', module).addWithInfo(
    'Defalut',
    `
      \tvalue: {
        \tcounter: number,
        \tisMin: bool,
        \tisMax: bool,
      \t}
    `,
    () => {
        // Story here
    }
)

@ndelangen ndelangen self-requested a review June 6, 2017 19:08
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 6, 2017
@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #1204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      536      531    -5     
=======================================
  Hits          611      611           
- Misses       3502     3514   +12     
+ Partials      476      464   -12
Impacted Files Coverage Δ
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.14% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 39.13% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64683a1...afc56fe. Read the comment docs.

@ndelangen
Copy link
Member

Thank you @nezed !

@ndelangen ndelangen merged commit a5de77a into storybookjs:master Jun 6, 2017
@nezed nezed deleted the patch-1 branch June 7, 2017 10:05
@ndelangen ndelangen changed the title Bug: Update marksy dependecy due broken 1.1.0 version Update marksy dependecy due broken 1.1.0 version Jun 7, 2017
nezed added a commit to kupibilet-frontend/ui that referenced this pull request Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants