Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD https import & remove tracking code remains #1176

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Conversation

ndelangen
Copy link
Member

Fixes: #1163

What I did

  • Added the missing import
  • Removed some code that should not be there anymore for tracking

How to test

Run storybook on https

@ndelangen
Copy link
Member Author

@doctyper Could you validate this ?

@codecov
Copy link

codecov bot commented Jun 1, 2017

Codecov Report

Merging #1176 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   13.31%   13.31%   +<.01%     
==========================================
  Files         199      199              
  Lines        4589     4588       -1     
  Branches      725      724       -1     
==========================================
  Hits          611      611              
  Misses       3349     3349              
+ Partials      629      628       -1
Impacted Files Coverage Δ
app/react/src/server/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61e0bc...16605b9. Read the comment docs.

Copy link
Contributor

@doctyper doctyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 3868a54 into master Jun 1, 2017
@ndelangen ndelangen added this to the v3.0.1 milestone Jun 2, 2017
@Hypnosphi Hypnosphi deleted the fix-https branch August 17, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants