Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-Toolbars: Global args support in the toolbar #10028

Merged
merged 14 commits into from
Mar 13, 2020
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 3, 2020

Issue: N/A

What I did

Created addon-toolbars, an evolution of addon-contexts, based on Storybook's new Global Args feature and decorators.

hero

This addon allows people to easily create custom toolbars that set global variables which are accessible from within decorators and stories. See included README for details.

How to test

See included toolbar stories in official-storybook

@shilman shilman changed the title Toolbars Addon Addon-Toolbars: Global args support in the toolbar Mar 3, 2020
@shilman shilman added this to the 6.0.0 milestone Mar 3, 2020
@shilman shilman marked this pull request as ready for review March 3, 2020 05:46
@leoyli
Copy link
Contributor

leoyli commented Mar 10, 2020

Thanks for creating this! The first look really promising to me. It did solve the pain point I was facing on porting the addon with other frameworks. Really well done guys! I will dive in deeper to see if anything I can suggest to make it even better.

@shilman shilman changed the base branch from feature/global-args to next March 12, 2020 07:44
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff

@shilman shilman merged commit e0c42a9 into next Mar 13, 2020
@shilman shilman deleted the feature/addon-toolbars branch March 13, 2020 12:20
@lifeiscontent
Copy link
Member

lifeiscontent commented Apr 30, 2020

@shilman where do the icons come from?

e.g. where can I know which icons I can use?

@shilman
Copy link
Member Author

shilman commented May 1, 2020

https://next--storybookjs.netlify.app/official-storybook/?path=/docs/basics-icon--labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants