-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Vite 3 #394
Support Vite 3 #394
Conversation
We're getting an error from |
Cool, after rebasing on to #410, the examples built successfully in the linux runner. The mac build ran out of memory, but otherwise looked like it would have succeeded. |
packages/builder-vite/package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"@mdx-js/mdx": "^1.6.22", | |||
"@storybook/csf-tools": "^6.4.3", | |||
"@storybook/source-loader": "^6.4.3", | |||
"@vitejs/plugin-react": "^1.0.8", | |||
"@vitejs/plugin-react": "^2.0.0-alpha.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting Vite 3.0 will be a breaking change due to this, since this version will fail with vite < 3.
Building the examples was running out of memory in the macOS runner, and my theory is that it is due to those runners having three cores, and yarn choosing to run two concurrent builds in parallel, which exceeds the memory available to node on those worker boxes. But they have 14gb of memory available, so I'm trying to bump the |
df931eb
to
e9310db
Compare
This updates the vite builder to support vite 3.0, which is a breaking change due to our use of @vitejs/plugin-react, which also has a new major version to support vite 3.
This also updates our examples to the latest vite and vite plugin beta versions.