Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 support #56

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Storybook 8 support #56

merged 3 commits into from
Apr 6, 2024

Conversation

literalpie
Copy link
Collaborator

I fixed most of the breaking changes, but getQueryParams is no longer available where we need it (it's available in the manager-api, but not preview-api). A good fix would require more work.

If there's demand, maybe we could let this package continue to limp along by just accepting that query param support will be incomplete.

dependencies also aren't right. We'd need to clean that up before releasing if we want to release.

@ArmorDarks
Copy link

While it's not merged yet, here is a fork with a pre-built dist.

For those who need it, just temporarily update package version to this:

"@storybook/addon-knobs": "github:ArmorDarks/addon-knobs#storybook-8",

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the dependencies to ^8 instead of directly depending on the RC?

@literalpie
Copy link
Collaborator Author

I actually can't figure out what breaks by removing knobValuesFromUrl. Everything seems to work the same as before:

  • Using the "copy" button to copy a URL and navigate to it applies the knob just like v7
  • Switching to a different story and back resets knob values, which is the same behavior as v7

I think it's worth releasing even if there is an issue. We can open a new issue to follow-up with a fix if someone does discover something broken by this.

Otherwise, I think this is in a good state to merge now.

@literalpie literalpie requested a review from shilman March 23, 2024 16:13
@literalpie literalpie changed the title Storybook 8 WIP Storybook 8 support Mar 23, 2024
@literalpie literalpie merged commit be9570b into storybookjs:main Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants