core: Add Encrypted.Convert method

[xyakimo1]

No description provided.

[StorageGhoul]

Can one of the admins verify this patch?

[packit-as-a-service]

Cockpit tests failed for commit 433ed08. @martinpitt, @jelly, @mvollmer please check.

[martinpitt]

OK, that's not cockpit's bug 😅

udiskslinuxencrypted.c:1301:9: error: implicit declaration of function 'bd_crypto_luks_convert'; did you mean 'bd_crypto_luks_close'? [-Werror=implicit-function-declaration]
 1301 |   if (! bd_crypto_luks_convert (udisks_block_get_device (block),
      |         ^~~~~~~~~~~~~~~~~~~~~~
      |         bd_crypto_luks_close
udiskslinuxencrypted.c:1301:9: warning: nested extern declaration of 'bd_crypto_luks_convert' [-Wnested-externs]

[vojtechtrefny]

OK, that's not cockpit's bug 😅

udiskslinuxencrypted.c:1301:9: error: implicit declaration of function 'bd_crypto_luks_convert'; did you mean 'bd_crypto_luks_close'? [-Werror=implicit-function-declaration]
 1301 |   if (! bd_crypto_luks_convert (udisks_block_get_device (block),
      |         ^~~~~~~~~~~~~~~~~~~~~~
      |         bd_crypto_luks_close
udiskslinuxencrypted.c:1301:9: warning: nested extern declaration of 'bd_crypto_luks_convert' [-Wnested-externs]

We need libblockdev daily builds for this, the version with bd_crypto_luks_convert is not yet released.

[vojtechtrefny]

/packit build

[vojtechtrefny]

Jenkins, ok to test.

[vojtechtrefny]

Jenkins, test this please.

[vojtechtrefny]

/packit build

[tbzatek]

No objections for the code itself, looks good. However please do take care to properly follow the code style and block indentation. Have a look at surrounding code to see how nested blocks are formatted.

[vojtechtrefny]

Looks good to me, thank you.

The test failures in our CI are unrelated and we just need to make sure to wait for the new release of libblockdev before merging this to not break the cockpit test suite.

[martinpitt]

We need libblockdev daily builds for this

Aren't these supposed to be in https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/packages/ ? The last libblockdev build is from 4 days ago, much newer than this PR. What happened here?

[vojtechtrefny]

/packit test

[vojtechtrefny]

We need libblockdev daily builds for this

Aren't these supposed to be in https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/packages/ ? The last libblockdev build is from 4 days ago, much newer than this PR. What happened here?

There was an issue with the libblockdev daily builds, the version in the udisks-daily repo was behind the version in Fedora for some time. That should be fixed now. (I originally thought that the revdeps test doesn't use the daily build repo and that was the reason for the failures.)

[tbzatek]

Looks good! Thanks for your contribution.