Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] split SoftwareFrameworkTests from simple testbench simulation #820

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Feb 20, 2024

This PR is based on #817 , so I'll keep it as a draft until that one is merged.

Instead of building the processor check software together with other "toolchain testing software compilation" tasks, it is done at the same time the simulation is to be executed, in a separated job.
Moreover, since building the software and running the simulation was done using the same container image but in different steps (thus, spawning two containers), I changed it to call make target sim-check (from #817) directly.

By the way, I removed 'Container' from job names/ids, since currently all the steps are executed on containers. I believe that's just a leftover from some years ago, when the simple testbench was executed on GitHub's Ubuntu environment.

@umarcor umarcor added the CI Continuous integration-related label Feb 20, 2024
@umarcor umarcor marked this pull request as ready for review February 21, 2024 00:04
@umarcor
Copy link
Collaborator Author

umarcor commented Feb 21, 2024

This is now rebased, after merging #817.

@stnolting stnolting merged commit 0885938 into stnolting:main Feb 21, 2024
6 checks passed
@umarcor umarcor deleted the umarcor/ci-processor-split branch February 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants