Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardware tigger module (Sdtrig) to version 1.0 #739

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Conversation

stnolting
Copy link
Owner

This PR upgrades the CPU's hardware trigger module (Sdtrig ISA extension) to v1.0 and also fixes some bugs present in the previous version.

  • upgrade Sdtrig from version 0.13 to version 1.0
  • replace mcontrol trigger (deprecated) by mcontrol6 trigger
  • fix invalid write access to tdata* CSRs when dmode is set an CPU is not in debug-mode
  • fix "timing" of hardware trigger match
    • the trigger module now generates a breakpoint exception / enter debug-mode when execution reaches the programmed address but before actually executing the instruction at that address
    • i.e. mepc/dpc will point to the next instruction that has to be executed (after returning from exception / after returning from debug-mode) to preserve program flow

@stnolting stnolting added bug Something isn't working enhancement New feature or request risc-v compliance Modification to comply with official RISC-V specs. HW hardware-related labels Nov 30, 2023
@stnolting stnolting self-assigned this Nov 30, 2023
@stnolting stnolting marked this pull request as ready for review November 30, 2023 17:20
@stnolting stnolting merged commit 682fe6b into main Nov 30, 2023
8 checks passed
@stnolting stnolting deleted the sdtrig_update branch November 30, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request HW hardware-related risc-v compliance Modification to comply with official RISC-V specs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant