Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor rtl edits #684

Merged
merged 6 commits into from
Sep 12, 2023
Merged

minor rtl edits #684

merged 6 commits into from
Sep 12, 2023

Conversation

stnolting
Copy link
Owner

  • constrain configuration generics (via range)
  • minor VHDL code cleanups
  • update AXI wrapper; add missing configuration options and signals

@stnolting stnolting added the HW hardware-related label Sep 11, 2023
@stnolting stnolting self-assigned this Sep 11, 2023
@stnolting stnolting marked this pull request as ready for review September 11, 2023 19:40
@NikLeberg
Copy link
Collaborator

NikLeberg commented Sep 11, 2023

Since you are already updating the dm: I have noticed during my multi-hart extension that the member progbuf in the dci_t record is not used anywhere. Seems to be a leftover of a refactoring.

index 6622cc16..e738a624 100644
--- a/rtl/core/neorv32_debug_dm.vhd
+++ b/rtl/core/neorv32_debug_dm.vhd
@@ -215,7 +215,6 @@ architecture neorv32_debug_dm_rtl of neorv32_debug_dm is
     execute_req   : std_ulogic; -- DM wants CPU to execute program buffer when set
     execute_ack   : std_ulogic; -- CPU starts executing program buffer when set (single-shot)
     exception_ack : std_ulogic; -- CPU has detected an exception (single-shot)
-    progbuf       : std_ulogic_vector(255 downto 0); -- program buffer, 4 32-bit entries
     data_we       : std_ulogic; -- write abstract data
     data_reg      : std_ulogic_vector(31 downto 0); -- memory-mapped data exchange register
   end record;

@stnolting
Copy link
Owner Author

You are right! Thanks for noticing!

@stnolting stnolting merged commit 7d67873 into main Sep 12, 2023
8 checks passed
@stnolting stnolting deleted the dev110923 branch September 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants