Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename logical library 'iCE40UP' to 'iCE40' #67

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jun 11, 2021

Although we've been using the sb_ice40_components source for UP5K devices only, some of those can be used with other ICE40 devices too. This PR renames the logical library name from iCE40UP to iCE40.

By the way, .gitignore is updated.

@umarcor umarcor mentioned this pull request Jun 11, 2021
@stnolting
Copy link
Owner

Although we've been using the sb_ice40_components source for UP5K devices only, some of those can be used with other ICE40 devices too. This PR renames the logical library name from iCE40UP to iCE40.

Very good idea!

@stnolting stnolting merged commit 2d8fa93 into stnolting:master Jun 11, 2021
@umarcor umarcor deleted the ice40 branch June 11, 2021 12:23
@stnolting
Copy link
Owner

Lattice Radiant cannot resolve iCE40 library if not explicitly assigned.
Reverting the library fixes in the plain-radiant example setup should not break anything, right? 😅

stnolting added a commit that referenced this pull request Jun 13, 2021
#67)

Lattice Radiant cannot resolve iCE40 library if not explicitly assigned.
@umarcor
Copy link
Collaborator Author

umarcor commented Jun 16, 2021

I see. So, when using radiant all the component libraries are automatically added to the project under the hood. You don't see them, but you can instantiate them. That makes sense. Sorry about breaking that 😟

@stnolting
Copy link
Owner

No worries! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants