[sw/uart] allow for escaped percent sign #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikLeberg
force-pushed
the
sw/printf_percentage_escape
branch
from
0d4a6ab
to
096a683
Compare
|
Hi Nik, and i use for advanced printing nanoprintf. |
NikLeberg
force-pushed
the
sw/printf_percentage_escape
branch
from
096a683
to
a24036e
Compare
Done. Thanks for the feedback and ideas! |
stnolting
approved these changes
Mar 4, 2023
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
The current
printfimplementation did not allow me to print a single%by escaping it with an additional percent sign in front%%. This is supported in the standard implementation.If I put two, it printed out two. If I put only one, it printed
%<break>with cutecom (Maybe misconfiguration on my end? PuTTY correctly showed only%.)Anyway this small pr adds support for it.
I assume that the custom implementation of
printfis deliberately kept small and need not be compliant with all the quirks of the official rules (for example floats are left out). So feel free to decline this pr if it would add to much bloat.Cheers, Nik