🧪 try to fix *_reduce_f functions usage for gate-level simulation #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not use function result for direct signal assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the
*_reduce_ffunctions from the NEORV32 package are used.If the function result is used for direct signal assignment this can cause undefined (
'X'or'U') signal states, which might corrupt gate-level simulation.Current (pre-PR):
some_signal <= or_reduce_f(another_signal);Proposed (post-PR):
Furthermore, synthesis seems to be able to do better optimizations when using the changes from this PR (at least Intel Quartus).
There are no functional (real hardware) changes caused by this PR.