🐛 [BUSKEEPER] fix bug in error flag logic #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to changes in the NEORV32 RTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the BUSKEEPER's error flag logic that was introduced in #247 (version
1.6.5.4). The bug did not effect the actual functionality of the module - it just issued wrong error types for certain bus errors.Thanks to @emb4fun for finding this bug! 👍
This PR also removes the BUSKEEPER's "unexpected ACK" and "unexpected ERR" detection logic and error codes (those situation cannot be handled by the CPU). Hence, the number of bits indicating the actual bus error cause are reduced to one (just BUSKEEPER_ERR_TYPE).