Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Make PWM and XIRQ IOs fixed-sized #241

Merged
merged 7 commits into from
Dec 23, 2021
Merged

Conversation

stnolting
Copy link
Owner

This PR modifies the top entity's pwm_o and xirq_i ports. Both ports have now a fixed size that corresponds to the maximum value of the according configuration generics (rather than being size-defined by those generics). I think this is more straight-forward as all other IOs (except for the CFS ones) have a fixed size, too.

-- PWM (available if IO_PWM_NUM_CH > 0) --
pwm_o : out std_ulogic_vector(59 downto 0); -- pwm channels
-- External platform interrupts (available if XIRQ_NUM_CH > 0) --
xirq_i : in  std_ulogic_vector(31 downto 0) := (others => 'L'); -- IRQ channels

@stnolting stnolting added the HW hardware-related label Dec 21, 2021
@stnolting stnolting self-assigned this Dec 21, 2021
@stnolting stnolting marked this pull request as ready for review December 22, 2021 13:39
@stnolting stnolting merged commit 5d692e6 into master Dec 23, 2021
@stnolting stnolting deleted the pwm_xirq_io_size branch December 23, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant