🐛 Fix Wishbone timeout bug #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed timeout counter sizes (WISHBONE & BUSKEEPER)
|
I had yesterday some problems with running code out of the SDRAM, TIMEOUT_ERR. Before the fix it was not working even with a timeout value of 8191. Now it works |
|
Great to hear! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Wishbone timeout counter.
Wishbone timeout configurations (via the
MEM_EXT_TIMEOUTgeneric) that are a power of two (like 256) caused an immediate timeout exception since the timeout counter was one bit short.The same problem occurred in the BUSKEEPER's timeout counter. However, this bug did not actually appeared because the default BUSKEEPER timeout is not a power of two.
Thanks to @emb4fun for identifying this bug. 👍