Fix neorv32_gpio_port_get() #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function should read from: - NEORV32_GPIO.INPUT_LO and NEORV32_GPIO.INPUT_HI But previously it was reading from: - NEORV32_GPIO.OUTPUT_LO and NEORV32_GPIO.OUTPUT_HI So it wasn't working correctly. The function neorv32_pin_get() was reading the correct values (from INPUT instead of OUTPUT) and thus it was working correctly.
stnolting
approved these changes
Nov 29, 2021
|
Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function should read from:
But previously it was reading from:
So it wasn't working correctly. The function neorv32_pin_get() was
reading the correct values (from INPUT instead of OUTPUT) and thus it
was working correctly.