Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce_f won't work with single bit operands #186

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

gottschalkm
Copy link
Contributor

The or_reduce_f, and_reduce_f, and xor_reduce_f won't work for single bit as the condition fails.
This produces some bugs in the interrupt controller (signal irq_fire) if only one interrupt line is used.

@stnolting stnolting added bug Something isn't working good first issue Good for newcomers labels Oct 18, 2021
@stnolting
Copy link
Owner

Thanks for fixing!

@stnolting stnolting merged commit 5a50a38 into stnolting:master Oct 18, 2021
@stnolting stnolting added the HW hardware-related label Oct 18, 2021
@umarcor
Copy link
Collaborator

umarcor commented Oct 19, 2021

@stnolting I think you are misunderstanding the purpose of label good first issue. That is typically used for new contributors who want to help with some task, so they can more easily find pending issues to help at. However, here you used it "post-mortem", to indicate that you think this was a good contribution for a first time contributor. For that purpose, I believe it's better to use reactions (:heart:) or to be vocal about it:

@gottschalkm this was a nice fix! Congrats and welcome to the list of contributors!

Naturally, you are free to use labels as you want. However, this specific label is a convention across multiple repos, similarly to the hacktoberfest.

@stnolting stnolting removed the good first issue Good for newcomers label Oct 19, 2021
@stnolting
Copy link
Owner

I'm still not sure how to handle all those labels - maybe we ( I ) need an issue/discussion to define a list of labels... 😅
Anyway, thanks for clearing 😄

@gottschalkm gottschalkm deleted the reduce_function_fix branch December 9, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HW hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants