Fix source/sink mixup in SLINK docs #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also explicitly state which end controls which signal
umarcor
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Not necessarily in this PR, but I suggest adding a reference to https://developer.arm.com/documentation/ihi0051/a/Introduction/About-the-AXI4-Stream-protocol. Even though NEORV32 is not AXI4 Stream compliant, it does implement the very basic handshake mechanism.
|
Added the link also. |
|
Thanks for the fix + improvement! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also explicitly state which end controls which signal.