Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add COM port prefix in bmp_upload pattern on Windows #1737

Merged
merged 1 commit into from
Jun 8, 2022
Merged

fix: add COM port prefix in bmp_upload pattern on Windows #1737

merged 1 commit into from
Jun 8, 2022

Conversation

reppad
Copy link
Contributor

@reppad reppad commented Jun 7, 2022

This PR fixes the following bug

This PR adds a variant of upload.pattern for bmp_upload on Windows.
This variant adds the prefix \\.\ to the COM port.
Without this prefix, the command only works for COM ports < 10 (1 single digit).

Always adding the prefix works fine for me, @esden from the Black Magic Debug project has confirmed that there is no issue doing that.
blackmagic-debug/blackmagic#1042 (comment)

Fixes #1377

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reppad

@fpistm fpistm added the fix 🩹 Bug fix label Jun 8, 2022
@fpistm fpistm added this to the 2.3.0 milestone Jun 8, 2022
@fpistm fpistm merged commit bcf0574 into stm32duino:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Magic Probe with a two-digit COM port on Windows won't work
2 participants