Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the pipeline to validate that packaging a jar works properly #801

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

johnjaylward
Copy link
Contributor

@johnjaylward johnjaylward commented Oct 16, 2023

Fixes #796

See also #793, #761 and #760

What problem does this code solve?

Re-adds proper support for Modules on Java 9+. PR #761 was not tested with builds using JDK 8 and the changes only worked when using JDK 9+.

  • Validate that the mvn package step completes during the pipeline
  • fix issue with package step failing when run on jvm8
  • Update the README.md to have correct supported versions
  • Adds package artifacts to Action results. see the Actions -> Artifacs section for compiled JARs

A Follow-on PR that enables distribution through GitHub Actions would be worthwhile.

Risks

Low. Changes add new steps to the GitHub actions to ensure that packaging works properly going forward and will only affect the JAR creation

Changes to the API?

None

Will this require a new release?

Yes

Should the documentation be updated?

No, but slight changes were made to the README to:

  1. Include workflow status badges
  2. Correct the supported Java versions

Does it break the unit tests?

No. New GitHub actions were added to ensure that similar changes will not break release management going forward.

Was any code refactored in this commit?

No.

Review status

APPROVED

Starting 3-day comment window

@johnjaylward johnjaylward marked this pull request as draft October 16, 2023 13:40
@johnjaylward johnjaylward marked this pull request as ready for review October 16, 2023 17:29
@johnjaylward johnjaylward changed the title DRAFT: Updates the pipeline to validate that packaging a jar works properly Updates the pipeline to validate that packaging a jar works properly Oct 16, 2023
@johnjaylward
Copy link
Contributor Author

@stleary can you re-run the last set of jobs, they worked on branch, but not in the PR for some reason

@johnjaylward
Copy link
Contributor Author

@stleary , this is ready for review now.

@stleary
Copy link
Owner

stleary commented Oct 16, 2023

Nice work, thanks!

@stleary stleary merged commit 996d3a5 into stleary:master Oct 20, 2023
5 checks passed
@johnjaylward johnjaylward deleted the updateActionsForDeploy branch October 20, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy to Maven with Module Info changes in pom.xml
2 participants