Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live demo #39

Closed
dandv opened this issue Jun 1, 2015 · 8 comments
Closed

Add live demo #39

dandv opened this issue Jun 1, 2015 · 8 comments
Labels
enhancement

Comments

@dandv
Copy link

dandv commented Jun 1, 2015 •
edited
Loading

Also requested between the lines in #29.

I'm comparing a bunch of editors and a live demo would help.
@steveathon
Copy link
Owner

Agreed. We need to add live demos, we will add them on the gh-pages branch. Likewise, in #29 we'll update those to make them work with the updated bower.

@steveathon steveathon mentioned this issue Jun 15, 2015
Closed
@codewithtyler codewithtyler mentioned this issue Aug 14, 2015
Merged
steveathon added a commit that referenced this issue Aug 28, 2015
@steveathon
Merge pull request #54 from RandomlyKnighted/gh-pages
b93774f 
Added bower.json file
Fixes #29 and #39 by adding a live demo to the website
Removed bower since we use CDN for links
Switched Google Code Prettify to CDN
Migrated jquery.hotkeys from manual management to management using bower
Changed folder structure and updated bootstrap-wysiwyg to newly released
Updated basic usage section and included syntax highlighting
@codewithtyler
Copy link
Contributor

This issue can now be closed per PR #54. You can now find the live demo at: http://steveathon.github.io/bootstrap-wysiwyg/

@dandv
Copy link
Author

dandv commented Aug 28, 2015

Thanks. The demo doesn't work right now though: I can't type anything, and the console shows http://steveathon.github.io/bootstrap-wysiwyg/bower_components/jquery.hotkeys/jquery.hotkeys.js couldn't load.

@codewithtyler
Copy link
Contributor

That's right, I forget that Jekyll can't handle using Bower libraries. Unfortunately, there is not a CDN anywhere that hosts jquery.hotkeys so I'm in the process of getting it added to cdnjs.com. My PR is here. As soon as it gets merged I'll update the site with the link to the new CDN file.

@dandv
Copy link
Author

dandv commented Aug 28, 2015

JSDelivr might make it easier to get the library on its CDN?

@codewithtyler
Copy link
Contributor

Thanks @dandv I'll see about getting it added to that as well. If all goes well the demo might be updated sooner than expected.

@codewithtyler
Copy link
Contributor

I've added a PR for JSDelivr as well. Hopefully we'll get things worked out soon and I'll be able to update the site.

@codewithtyler
Copy link
Contributor

This has been fixed. It can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dandv @steveathon @codewithtyler