Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README (launch args instead of yaml) #135

Open
2 tasks done
FlorianPix opened this issue Feb 16, 2023 · 0 comments
Open
2 tasks done

fix README (launch args instead of yaml) #135

FlorianPix opened this issue Feb 16, 2023 · 0 comments
Labels
feature_request New feature or request

Comments

@FlorianPix
Copy link

Preliminary Checks

  • This issue is not a duplicate. Before opening a new issue, please search existing issues.
  • This issue is not a question, bug report, or anything other than a feature request directly related to this project.

Proposal

The zed.launch.py, zedm.launch.py, zed2.launch.py and zed2i.launch.py are three Python scripts that automatically start the ZED node using "manual composition", loading the parameters from the correct "YAML files" and creating the camera model from the correct "URDF file".

Note: You can set your own configurations modifying the parameters in the files common.yaml, zed.yaml zedm.yaml, zed2.yaml and zed2i.yaml available in the folder zed_wrapper/config. For full descriptions of each parameter, follow the complete guide here.

This is not completly correct as a lot of the settings you make in the yaml files are overwritten by the launch files.

For example I had to change the command I use to run the wrapper because the settings I made in the yaml files didn't work anymore when I checked out the most current commit.

ros2 launch zed_wrapper zed2.launch.py publish_tf:=false publish_map_tf:=false base_frame:="camera_mount"

Also the link to the parameter description doesn't work at the moment.

Use-Case

No response

Anything else?

No response

@FlorianPix FlorianPix added the feature_request New feature or request label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature or request
Development

No branches or pull requests

1 participant