Fix ROI mask always being invalid #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Region of Interest mask always being invalid for the entire image when toggled. In SDK v4.0, Region of Interest mask can no longer be populated with '1' to indicate a valid pixel; must use '255'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Region of Interest mask always being invalid for the entire image when toggled.
Appears that since SDK v4.0, the Region of Interest matrix can no longer be populated with
1to indicate that that pixel is valid. Per the API Reference, the value must now be >=127. To be safe, I've used 255.With the current code, if
roi=TRUE, the depth map will be all 0 (since the ROI matrix will be set as all invalid)