Fixing build for UE 5.3 with BuildSettingsVersion.V4 enabled #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling EngineIncludeOrderVersion.Unreal5_3 in build script caused a lot of errors with missing files. This commit just fixing these includes and adds Core dependency to the plugin.
SLJLMacarit
requested review from
Bvallon-sl and
SLJLMacarit
and removed request for
Bvallon-sl
SLJLMacarit
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this issue: #39
Also fixes another minor issues:
Please note that this PR isn't that huge, from 619 changed files, around 600 of them are removed Eigen library files.
I also checked if the project now builds successfully with any of these oprions enabled or disabled - it does, so this PR shouldn't affect projects that already using this plugin.