Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for database backup (sqlite3_backup_init) #919

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

kkapitan
Copy link
Contributor

Hi,

First of all - thank you for this amazing utility! My team and I are using this in some parts of our application and we are planning to expand the usage even further. However one feature of sqlite that we rely on is the ability to dump in memory databases to a file. It would be great to have that as a part of this library and that's why I'm leaving this Pull Request here with an example implementation.

I'm happy to hear any feedback from you and thanks again for your work!

sergeymild added a commit to sergeymild/SQLite.swift that referenced this pull request Jun 9, 2020
@jberkel
Copy link
Collaborator

jberkel commented Aug 21, 2021

@kkapitan thanks for the PR, looking good. I think the API would be more intuitive if the source parameters came first:

return try Backup(sourceConnection: self,
                  sourceName: databaseName,
                  targetConnection: targetConnection,
                  targetName: targetDatabaseName)

@jberkel jberkel merged commit e7bed4a into stephencelis:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants