Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deployment targets for Xcode 15 and add dependency on custom Cocoapods fork #1255

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

SagarSDagdu
Copy link
Contributor

@SagarSDagdu SagarSDagdu commented Apr 13, 2024

This PR demonstrates how to fix the issue of not being able to push podspec to Cocoapods from Xcode 15 due to minimum deployment target issues.
Check this comment for more information: #1250 (comment)

@SagarSDagdu
Copy link
Contributor Author

@nathanfallet iOS 12 is the minimum deployment target for Xcode 15.
Ref: https://developer.apple.com/support/xcode/
Screenshot 2024-04-13 at 5 40 04 PM

@nathanfallet
Copy link
Collaborator

Yeah sorry I noticed it after asking. Also, it's marked as WIP, can this be merged? At least I'm trying to publish the update based on your branch, it's building...

@SagarSDagdu SagarSDagdu changed the title [WIP] Change deployment targets for Xcode 15 and add dependency on custom Cocoapods fork Change deployment targets for Xcode 15 and add dependency on custom Cocoapods fork Apr 13, 2024
@SagarSDagdu
Copy link
Contributor Author

Hey @nathanfallet,this can be merged

@nathanfallet nathanfallet merged commit 0435dd1 into stephencelis:master Apr 13, 2024
2 checks passed
@nathanfallet
Copy link
Collaborator

@SagarSDagdu Thank you for your time helping to solve this issue!
Also note that when cocoapods will officially update to support this we will go back to the original track (so just remove Gemfile + Gemfile.lock)

@SagarSDagdu
Copy link
Contributor Author

Hey @nathanfallet, it is a pleasure contributing to this repo.
Yes, we can go back to the original track once Cocoapods fixes this, I will keep track of this and create a PR in the future.

@nathanfallet
Copy link
Collaborator

nathanfallet commented Apr 13, 2024

Also note that this one will have to be reverted at the same time (otherwise it won't work I guess)
c4ec236

@SagarSDagdu
Copy link
Contributor Author

@nathanfallet Noted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants