SchemaReader: return the correct column definition for a composite primary key #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PRAGMA
table_info
that is used to return the column definitions, returns one row for each defined column. Thepk
column contains:See https://www.sqlite.org/pragma.html#pragma_table_info
Checking whether the
pk
column equals 1 only detects a single primary key and ignores other columns that are part of a composite primary key.Thanks for taking the time to submit a pull request.
Before submitting, please do the following:
make lint
to check if there are any format errors (install swiftlint first)swift test
to see if the tests pass.